Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Service: introduce VerificationContext #3675

Closed
wolf4ood opened this issue Nov 30, 2023 · 0 comments · Fixed by #3677
Closed

Identity Service: introduce VerificationContext #3675

wolf4ood opened this issue Nov 30, 2023 · 0 comments · Fixed by #3677
Assignees
Labels
breaking-change Will require manual intervention for version update core feature enhancement New feature or request

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Nov 30, 2023

Feature Request

As part of the #3662 we want the IdentityService to receive extra/additional contextual information about the current verification call.

Which Areas Would Be Affected?

core

Why Is the Feature Desired?

IdentityService implementors could provide additional checks/logic based on the verification context

Solution Proposal

The IdentityService#verifyJwtToken will be changed:

from:

Result<ClaimToken> verifyJwtToken(TokenRepresentation tokenRepresentation, String audience);

to:

Result<ClaimToken> verifyJwtToken(TokenRepresentation tokenRepresentation, VerificationContext context); 

For now the VerificationContext will contain the audience for backward compatibility and a Policy that's associated
with the current verification process.

Policy extraction for the current context will be tacked in separated PRs accordingly to their area (catalog,transfer process, contract negotiation)

@wolf4ood wolf4ood added feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Nov 30, 2023
@wolf4ood wolf4ood added enhancement New feature or request core feature and removed feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Nov 30, 2023
@wolf4ood wolf4ood self-assigned this Nov 30, 2023
@wolf4ood wolf4ood added the breaking-change Will require manual intervention for version update label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update core feature enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant