Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDP VC/VP Verification: create URI-equality comparison that ignores the fragment #3650

Closed
paullatzelsperger opened this issue Nov 23, 2023 · 0 comments · Fixed by #3660
Closed
Assignees
Labels
dcp feature_request New feature request, awaiting triage
Milestone

Comments

@paullatzelsperger
Copy link
Member

Feature Request

the VC/VP Data Integrity specification requires in numerous places, that two URIs be the same, for example the issuer and the verificationMethod contained in the proof object. These items typically are URIs.

Normally, the issuer would contain the general resource identifier, e.g. did:web:the-issuer, while the verification method would contain a URI fragment, indicating the key material used to create the proof, e.g. did:web:the-issuer#signing-key-1.

Using the JDKs URI#equals method will always fail in those cases, because it will include the fragment.

Thus, we need our use-case specific URI comparison.

Which Areas Would Be Affected?

VC/VP verification

Why Is the Feature Desired?

Compliance with the spec.

Solution Proposal

convert the URIs to a string, chop off the fragment, perform string equals comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcp feature_request New feature request, awaiting triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant