Incompatibility between exchange categories addition in diagram and VP diagram styler

[LisaF268]

When VP diagram styler is active on a diagram, it is not possible to add exchange categories.

It is necessary to deactivate the viewpoint to add an exchange category on the diagram.

[SteveMonnier]

Capella2061_exchange_category.zip
Steps to reproduce:

• Import the Capella project from the attached archive
• Open the existing LAB diagram
• Select "FunctionalExchange 1" and go to the properties view
• The field "Exchange category" should be empty. Select the "..." button
• On the "Transfer Dialog", double click on "ExchangeCategory1" to move it on the right side. Click on OK.
  -> Validation: Check that "ExchangeCategory1" has been added to the field.

[pdulth]

Steps to reproduce:

• Create a PVMT model applied on Functional Exchange
  
• Create an architecture blank diagram displaying an Functional Exchange
• Display Diagram Styler layer and color the exchange by applying the PVMT property value
• Create an Exchange Category on the Functional Exchange
• The Switch Exchange Category display an empty wizard if the Diagram Styler layer is enabled.

[SteveMonnier]

Capella2061_exchange_category_v2.zip
I recreated my sample from Capella master branch and without requiring the VPMS viewpoint that wasn't needed in this context.
@pdulth your changes adding some other calls to DiagramServices.getDiagramServices().isMapping looks good to me, thanks.

[SteveMonnier]

Hi @pdulth @tguiu, I noticed that Philippe's commit has been pushed but I missed that Etienne's 2 commits had not been merged as well. I replayed my validation scenario with only your commit and I didn't see the ExchangeCategory in the Transfer dialog so I rebased the 2 commits on the master branch and created this PR: #2848
Thanks.

[pdulth]

Hi, Can you describe your validation scenario as for me it was ok with the fix.
#2061 (comment)

[SteveMonnier]

Hi,
oh right, I should have added a link as it is "further up" in older messages of this issue: this validation scenario and the scenario migrated for Capella 7.x is in a more recent comment.
Thanks @pdulth.

[roland-huber]

This problem also exists for Physical Link Categories.

[mPorhel]

Issue validated on FunctionalExchange with Version: 7.0.0 Build id: 202404171526 and the following updated sample (with PVMT 70.7.0 and Diagram Styler 70.3.1)

2061_exchange_category_v3_diagramStyler_enabled.zip

The patch proposed by Philippe is generic and deals with Sirius Mapping.
We have just tested with @SteveMonnier a few seconds ago with the addition of a Component Exchange Category in the provided sample + modification of the property scope. And the Switch Component Exchange / Category works fine.
It should be the same for Physical Link Exchange.

[SteveMonnier]

Hi. Indeed, we did some validation this morning and we found at that there had been an issue when I migrated the sample from 6.1 to 7.0. I migrated it again and it works with @pdulth commits. I abandonned the PR I created.