-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use All Cores by Default in Scanpy-Scripts #137
Comments
7 tasks
This is the block in scanpy-scripts where we can add the said argument, maybe name it as scanpy-scripts/scanpy_scripts/cli.py Lines 43 to 74 in 6297be2
|
We can apply this change once we've tested the sc tertiary pipeline on newer scanpy and scanpy-scripts versions. |
This PR addresses this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scanpy can use all cores by default with setting
sc.settings.n_jobs = -1
. This setting is not configured inscanpy-scripts
. Setting all cores by default would improve performance for computationally intensive tasks.Impetus, see comment:
ebi-gene-expression-group/scxa-tertiary-workflow#1 (comment)
Proposed Solution
Update
cli.py
in scanpy-scripts to include an argument for settingsc.settings.n_jobs
, where default issc.settings.n_jobs = -1
, ensuring all commands adopt the default.The text was updated successfully, but these errors were encountered: