From b18d30ed9c93bd6541758ec72caaf3c38e37d66b Mon Sep 17 00:00:00 2001 From: Andrew Gliga Date: Tue, 21 Jan 2025 08:55:37 -0800 Subject: [PATCH 1/2] fix(list): swapped to use marker --- .changeset/lemon-falcons-live.md | 5 +++++ dist/list/list.css | 7 ++++++- src/sass/list/list.scss | 7 ++++++- 3 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 .changeset/lemon-falcons-live.md diff --git a/.changeset/lemon-falcons-live.md b/.changeset/lemon-falcons-live.md new file mode 100644 index 0000000000..8e791125ba --- /dev/null +++ b/.changeset/lemon-falcons-live.md @@ -0,0 +1,5 @@ +--- +"@ebay/skin": minor +--- + +fix(list): swapped to use marker diff --git a/dist/list/list.css b/dist/list/list.css index 2eab3f1899..16abffd203 100644 --- a/dist/list/list.css +++ b/dist/list/list.css @@ -4,11 +4,16 @@ .list ol, .list ul { - list-style: none; margin: 0; padding: 0; } +.list ol li::marker, +.list ul li::marker { + content: ""; + font-size: 0; +} + .list fieldset > *, .list li > * { align-items: center; diff --git a/src/sass/list/list.scss b/src/sass/list/list.scss index bd0a18a7ec..c8a2ee1a63 100644 --- a/src/sass/list/list.scss +++ b/src/sass/list/list.scss @@ -8,11 +8,16 @@ .list ul, .list ol { - list-style: none; margin: 0; padding: 0; } +.list ul li::marker, +.list ol li::marker { + content: ""; + font-size: 0; +} + .list li > *, .list fieldset > * { @include background-color-token( From de5b6cbc87bf5beca02acfd8c723bfc3c28c558b Mon Sep 17 00:00:00 2001 From: Andrew Gliga Date: Tue, 4 Feb 2025 11:57:18 -0800 Subject: [PATCH 2/2] chore: removed extra selector --- dist/list/list.css | 3 +-- src/sass/list/list.scss | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dist/list/list.css b/dist/list/list.css index 16abffd203..0e7fec609c 100644 --- a/dist/list/list.css +++ b/dist/list/list.css @@ -8,8 +8,7 @@ padding: 0; } -.list ol li::marker, -.list ul li::marker { +.list li::marker { content: ""; font-size: 0; } diff --git a/src/sass/list/list.scss b/src/sass/list/list.scss index c8a2ee1a63..78f0b0e669 100644 --- a/src/sass/list/list.scss +++ b/src/sass/list/list.scss @@ -12,8 +12,7 @@ padding: 0; } -.list ul li::marker, -.list ol li::marker { +.list li::marker { content: ""; font-size: 0; }