Replies: 2 comments
-
I think, that's a great idea! |
Beta Was this translation helpful? Give feedback.
0 replies
-
I think, what we would also need is that the |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, the default
create_pipe
uses standard pipe types. The only value from the standard type library that is relevant to the pipeflow calculation is the diameter. (The main reason behind these standard types is the structure of pandapower - for power lines, many more parameters are read from the standard type library).To set the diameter individually, the
create_pipe_from_parameters
function has to be called. I have the impression that this one is much more relevant than "create using std_types".I'd like to discuss whether the default
create_pipe
function should rather be the one that is todaycreate_pipe_from_parameters
. It shouldn't be too complicated to pass everything to acreate_pipe_from_std_types
function, if astd_type=...
is being passed, so it could be backward-compatible.What do you think about the usage of standard types and the default create functions?
Beta Was this translation helpful? Give feedback.
All reactions