From 0a260f3ce2f7dc6cad36dfac8278fd058a2a0e53 Mon Sep 17 00:00:00 2001 From: danwt <30197399+danwt@users.noreply.github.com> Date: Mon, 6 Jan 2025 14:11:55 +0000 Subject: [PATCH] dont populate genesis info --- app/upgrades/drs-5-from2d/upgrade.go | 13 +++---------- go.mod | 2 +- go.sum | 4 ++-- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/app/upgrades/drs-5-from2d/upgrade.go b/app/upgrades/drs-5-from2d/upgrade.go index 9bd6aecd..1f7dc42e 100644 --- a/app/upgrades/drs-5-from2d/upgrade.go +++ b/app/upgrades/drs-5-from2d/upgrade.go @@ -46,16 +46,9 @@ func migrateHubGenesis(ctx sdk.Context, k hubgenkeeper.Keeper) error { Channel: "channel-0", } k.SetState(ctx, s) - - /* - We set PopulateGenesisInfo because the state it writes is used by GetBaseDenom - - - We need to set a dummy checksum otherwise PopulateGenesisInfo complains. - It's not actually used anywhere. - */ - k.SetGenesisInfo(ctx, hubgenesistypes.GenesisInfo{GenesisChecksum: "This is a placeholder - only exists for nim and mande due to migration - not real checksum"}) - return k.PopulateGenesisInfo(ctx, nil) + // Note: we won't populate genesis info. It has difficulties, such as missing checksum and denom metadata. + // It isn't needed for established chains. + return nil } func migrateRollappParams(ctx sdk.Context, k rollappparamskeeper.Keeper) error { diff --git a/go.mod b/go.mod index 26d8ddf1..c39bc0c9 100644 --- a/go.mod +++ b/go.mod @@ -369,6 +369,6 @@ replace ( // TODO: cleanup after rdk is merged //replace github.com/dymensionxyz/dymension-rdk => /Users/danwt/Documents/dym/d-dymension-rdk -replace github.com/dymensionxyz/dymension-rdk => github.com/dymensionxyz/dymension-rdk v1.8.0-rc02.0.20250106130345-02ca863760b8 +replace github.com/dymensionxyz/dymension-rdk => github.com/dymensionxyz/dymension-rdk v1.8.0-rc02.0.20250106141106-c4bf86e13eaf replace github.com/dymensionxyz/dymint => github.com/dymensionxyz/dymint v1.3.0-rc02.0.20250106124459-756b49ffdf0c diff --git a/go.sum b/go.sum index 579def26..d03bb3cc 100644 --- a/go.sum +++ b/go.sum @@ -577,8 +577,8 @@ github.com/dymensionxyz/cosmos-sdk v0.46.17-0.20241128210616-e9dfe47b8c73 h1:A0O github.com/dymensionxyz/cosmos-sdk v0.46.17-0.20241128210616-e9dfe47b8c73/go.mod h1:VPUuzF+l+ekSGPV7VVB8m0OMQfwp3QdKWNZjvkU3A1U= github.com/dymensionxyz/cosmosclient v0.4.2-beta.0.20241121093220-e0d7ad456fbd h1:V89QyOFM84o9w0iFdctMU6So8SS/Xt32JWAXGqJduT0= github.com/dymensionxyz/cosmosclient v0.4.2-beta.0.20241121093220-e0d7ad456fbd/go.mod h1:3weqpVj/TqTFpC0LjEB3H+HZSpm7BrQ1QkEg1Ahy6KY= -github.com/dymensionxyz/dymension-rdk v1.8.0-rc02.0.20250106130345-02ca863760b8 h1:L+0O1BlZfZtVrRQkQdlFDTUlFyG0qM49Z8ucMD61upo= -github.com/dymensionxyz/dymension-rdk v1.8.0-rc02.0.20250106130345-02ca863760b8/go.mod h1:PgFH4LETkSRpSJDfxsvNs3VCb//O1nkbAM+cZWYkaVU= +github.com/dymensionxyz/dymension-rdk v1.8.0-rc02.0.20250106141106-c4bf86e13eaf h1:jo12b6NffdTwP3IRWUmec0OVrlfuOx/wHAi0w20RbZ0= +github.com/dymensionxyz/dymension-rdk v1.8.0-rc02.0.20250106141106-c4bf86e13eaf/go.mod h1:PgFH4LETkSRpSJDfxsvNs3VCb//O1nkbAM+cZWYkaVU= github.com/dymensionxyz/dymint v1.3.0-rc02.0.20250106124459-756b49ffdf0c h1:tTwBWY63JcfNqB32TKI5TyNZ2vGhwP8I4N0hzsJy9V8= github.com/dymensionxyz/dymint v1.3.0-rc02.0.20250106124459-756b49ffdf0c/go.mod h1:sqE+4imdASE9lm63jv+K2zmOnclLJNZLPYbL9m6vR3o= github.com/dymensionxyz/evmos/v12 v12.1.6-dymension-v0.5.0-rc02 h1:G6rtzFNnzeYOHN33rkw0kMQX+xRantRLTip1AMXYmBg=