Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full nodes can continue processing blocks if NextSequencersHash is empty #1314

Open
srene opened this issue Jan 8, 2025 · 0 comments
Open

Comments

@srene
Copy link
Contributor

srene commented Jan 8, 2025

UpdateProposerFromBlock sets dymint state proposer to nil if block.Header.NextSequencersHash is empty.
This can cause the next block to panic on validation because state.GetProposerHash() returns empty with following message
panic: runtime error: cannot convert slice with length 0 to array or pointer to array with length 32
imo full nodes should restart as well when next sequencer hash is empty, although this is actually only a problem in 3d migration.
in sentinel rotation (only case where next sequencer can be empty) a fork is created and fullnode is frozen when fork is detected anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant