Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use p2p ValidationResult (Ignore) instead of just Accept/Reject #1311

Open
danwt opened this issue Jan 7, 2025 · 0 comments · May be fixed by #1325
Open

Use p2p ValidationResult (Ignore) instead of just Accept/Reject #1311

danwt opened this issue Jan 7, 2025 · 0 comments · May be fixed by #1325

Comments

@danwt
Copy link
Contributor

danwt commented Jan 7, 2025

TX/Block validator on new fork
    	// ValidationAccept is a validation decision that indicates a valid message that should be accepted and
    	// delivered to the application and forwarded to the network.
    	ValidationAccept = ValidationResult(0)
    	// ValidationReject is a validation decision that indicates an invalid message that should not be
    	// delivered to the application or forwarded to the application. Furthermore the peer that forwarded
    	// the message should be penalized by peer scoring routers.
    	ValidationReject = ValidationResult(1)
    	// ValidationIgnore is a validation decision that indicates a message that should be ignored: it will
    	// be neither delivered to the application nor forwarded to the network. However, in contrast to
    	// ValidationReject, the peer that forwarded the message must not be penalized by peer scoring routers.
    	ValidationIgnore = ValidationResult(2)
    	// internal
    	validationThrottled = ValidationResult(-1)

        Recommendation: make validator return ValidationResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant