Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prepare.sh, xtp.toml & can remove pdk main #23

Open
nilslice opened this issue Nov 1, 2024 · 3 comments
Open

update prepare.sh, xtp.toml & can remove pdk main #23

nilslice opened this issue Nov 1, 2024 · 3 comments
Assignees

Comments

@nilslice
Copy link
Member

nilslice commented Nov 1, 2024

If we update prepare.sh to require tinygo version 0.34+ (as well as whatever compatible go versions are supported), then we can remove the func main() {} stub we generate as it is no longer needed.

In xtp.toml, we need to then update the build command to include -buildmode c-shared param in the tinygo call.

@nilslice nilslice self-assigned this Nov 1, 2024
@bhelx
Copy link
Contributor

bhelx commented Nov 20, 2024

Did you pick this up already @nilslice ? If not, me or Muhammad can pick it up.

@nilslice
Copy link
Member Author

@bhelx not yet -- but curious if your issue in #25 is related to the 0.34 version?

@nilslice
Copy link
Member Author

(actually, nvm, I'm on 0.34 and can't repro)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants