Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using aws-sdk to generate parameters for direct upload #208

Open
janko opened this issue Aug 11, 2016 · 0 comments
Open

Using aws-sdk to generate parameters for direct upload #208

janko opened this issue Aug 11, 2016 · 0 comments

Comments

@janko
Copy link

janko commented Aug 11, 2016

It seems that a lot of carrierwave_direct's logic is generating query parameters for direct S3 upload. However, the aws-sdk gem already has this functionality. Also, carrierwave_direct's logic is Rails/HTML-specific, while aws-sdk generates these parameters as a Ruby hash, so you can use it either to generate HTML fields or to return a JSON response. Maybe carrierwave_direct could just leverage aws-sdk for generating these presign parameters?

@janko janko changed the title What is the advantage of carrierwave_direct over aws-sdk? Using aws-sdk to generate parameters for direct upload Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant