Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: github projects sidebar #79

Open
mtstickney opened this issue May 9, 2015 · 1 comment · May be fixed by #83
Open

Regression: github projects sidebar #79

mtstickney opened this issue May 9, 2015 · 1 comment · May be fixed by #83

Comments

@mtstickney
Copy link

Commit ceb4837 moved external scripts from <head> to the <body> tag, which has broken the github projects sidebar. The sidebar uses javascript that depends on ender.js, but the sidebar script is inserted before the ender <script> tag after this change, so the projects are never loaded.

The fix is either to a) move the script tags above the sidebar include, or b) put them back in <head>. I didn't make a pull request, since I'm not sure which way you want to go, but I can if you'd like.

Edit: bah, markup problems.
@atodorov
Copy link
Contributor

atodorov commented Jun 4, 2016

For the record this has been fixed in 3cb2628 and can be closed.

@mtstickney mtstickney linked a pull request Jun 5, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load scripts before plugins that might use them. mtstickney/pelican-octopress-theme
2 participants
@mtstickney @atodorov