Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating new CTFs and challenge channels do not check the channel limit on the guild #63

Open
mklarz opened this issue Apr 20, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mklarz
Copy link
Contributor

mklarz commented Apr 20, 2021

The bot does not check if the channel limit has been reached for discord guild. The bot adds a channel to its DB and attempts to create the channel, but then errors out.

We need to add a check on !create and !add.

Might be worth adding a check for !voice as there is a limit there as well #29

@mklarz
Copy link
Contributor Author

mklarz commented Apr 21, 2021

There is also a limit of 50 channels per category, which will cause issues if someone is playing multiple CTFs or a larger CTF, as the working and done category will most likely reach the limit.

This means that we need to be able to extend the "done" category into multiple ones. This can be done easily once #12 has been completed.

@mklarz
Copy link
Contributor Author

mklarz commented Apr 23, 2021

Regarding the last comment, the logic behind archive solves this issue by appending a counter to the end of the category name, and working + done should do the same. See #72

@mklarz mklarz added the bug Something isn't working label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant