Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channels/Categories should use ID instead of their names #45

Open
mklarz opened this issue Apr 16, 2021 · 0 comments
Open

Channels/Categories should use ID instead of their names #45

mklarz opened this issue Apr 16, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mklarz
Copy link
Contributor

mklarz commented Apr 16, 2021 •
edited
Loading

This can cause issues with channels with duplicate names. See for example https://github.com/ekofiskctf/fiskebot/blob/5a7802b9f894a6351dc5cab99bb778131af7cd3f/bot/ctf_model.py#L776 and https://github.com/ekofiskctf/fiskebot/blob/5a7802b9f894a6351dc5cab99bb778131af7cd3f/bot/bot.py#L215

A solution to this would be to implement #12 and save the IDs during !setup and rather just specify the names wanted in the configuration. That way we won't get issues with channel renaming etc.

Related issue for the logging channel: #34
@mklarz mklarz changed the title The export channel should use ID instead of a channel name Channels/Categories should use ID instead of their names Apr 16, 2021
@mklarz mklarz added enhancement New feature or request good first issue Good for newcomers labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mklarz