Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find(1) insead of directly passing /tools/lib to strip(1). #68

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

takusuman
Copy link
Contributor

@takusuman takusuman commented Jan 24, 2022

Use find(1) insead of directly passing /tools/lib to strip(1).

This prevent those "strip: Warning: foo/bar is a directory" warnings, also strips all the libraries present.

--strip-unneeded instead of --strip-debug

Remove .*.cmd and Makefile files from /usr/include, not from the Linux kernel source tree

I think we don't want to "harm" the source tree, so we won't be needing to extract the source tarball two times.

This prevent those "strip: Warning: foo/bar is a directory" warnings, also strips all the libraries present.
@dslm4515
Copy link
Owner

Actually, I’ve been striping by hand using strip —strip-unneeded per directory. Sometimes if is just use —strip-debug on some binaries or libraries, file still says those are not stripped.

@takusuman
Copy link
Contributor Author

takusuman commented Jan 24, 2022

Actually, I’ve been striping by hand using strip —strip-unneeded per directory. Sometimes if is just use —strip-debug on some binaries or libraries, file still says those are not stripped.

Hmmmm, strange...
I thought it would still stripping.

@takusuman
Copy link
Contributor Author

Oh, what about using --strip-unneeded in everything instead of doing a two-step process?

@dslm4515
Copy link
Owner

Yes, that's what I've been using... if the binary/library still shows up as unstripped by file then I use --strip-unneeded. Then file shows it as "stripped"

@takusuman
Copy link
Contributor Author

Files that you've ran strip --strip-debug and still showed "unstripped" didn't have debug symbols on them, so strip hadn't any debug to strip (pun intended :) )

@dslm4515
Copy link
Owner

Yup!

I started looking seriously into stripping when building LLVM. `--strip-debug" left a lot of binaries/libraries unstripped.

I've noticed some packages offer to strip when installing. Might consider it if not ever planning to debug.

…e Linux kernel source tree

I think we don't want to "harm" the source tree, so we won't be needing to extract the source tarball two times.
@dslm4515 dslm4515 merged commit 76c1d92 into dslm4515:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants