Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Audit #64

Open
6 of 7 tasks
bmos opened this issue Mar 6, 2024 · 11 comments
Open
6 of 7 tasks

Accessibility Audit #64

bmos opened this issue Mar 6, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@bmos
Copy link

bmos commented Mar 6, 2024

It seems like we have some substantial room for improvement.
I'm not so familiar with Jekyll, but it seems like some of these fixes would be theme related and some would be a matter of potentially doing edits to header tags within articles (so that article headers start at h2 and cascade down from there.

https://accessibe.com/accessscan?website=feed.dsausa.org

Key areas for improvement:

  • Alt text for avatars. Ideally it would be descriptive, but even "the Pittsburgh DSA logo" would be a start. This would allow easier on-page navigation and (if descriptive) provide more information to users who can't see the details included in the logo design. Assigned: @bmos
  • Add skip to main content button at top of page: <a href="#maincontent" class="sr-only sr-only-focusable">Skip to main content</a> linking to the div with the classes container my-4 p-0. Assigned: @bmos
  • Show more/less buttons are built with input/label/span tags which means no keyboard navigation despite adding the tags for it. Need to figure out how to redesign using a button tag, ideally without JS. Assigned: @bmos
  • Adjust order of keyboard navigation within article info (should be title, author, skip the date, show more. Ideally we would only jump to links inside the article if it's expanded.
  • The DSA feed logo is inside an a tag but missing the href attribute. This could lead to confusing screenreader output if it's reported as a link. Assigned: @airbr
  • Some color, font, background combinations are lacking contrast. Assigned: @airbr
  • Work on headings to ensure that the pages include only headings of a proper hierarchical structure (h1, h2, h3, etc). There is likely only so much we can do since we are showing content from many places).
@bmos bmos added the enhancement New feature or request label Mar 6, 2024
@airbr
Copy link

airbr commented Mar 13, 2024

Hello @bmos , thank you for bringing this issue to wider attention. For context, I believe that this website was created with a burst of good development to get it working and now it is definitely in need of refinement.

I ran some tests that confirm what you are saying about issues with Accessibility.

I attach two screenshots that elaborate on this- A Lighthouse test score that captures the page state (couldn't get it to load navigation past cloudflare) that shows a bunch of detail about how we are failing some audits.
Screenshot 2024-03-12 at 9 29 46 PM

The W3C validator, basically the rolls royce of validators, raises a number of issues and also has an outline report which shows our heading structure needs improvement.

Screenshot 2024-03-12 at 9 31 06 PM

I feel able to help lead this work, but I don't want to do it alone as its actually quite a fun and good project it is going to be a big improvement when finished.

@airbr
Copy link

airbr commented Mar 13, 2024

Accessibility tools I am familiar with:

  • Lighthouse testing
  • W3C Validator aka. Nu HTML Checker
  • Axe Core with a front end testing library like Playwright

These are not a replacement for manual testing by people with accessibility tools but supplement.

Im happy to teach people about these tools if desired, and do some of the work myself

@airbr
Copy link

airbr commented Mar 13, 2024

@bmos @colinmahns I successfully cloned, built and served this website locally. I am ready to start working on this. Like I said, I want to ideally take someone along the journey too.

@victoria-riley-barnett
Copy link

victoria-riley-barnett commented Mar 13, 2024 via email

@airbr
Copy link

airbr commented Mar 13, 2024

@victoria-riley-barnett Awesome! good stuff, it was really cool pulling down all the blog posts and looking at them.

The stuff that these tests pull are often generally not as noticeable unless you have the issue - the color contrast looks fine to me for example, but the tests are saying we could improve that in some areas. Ive seen this happen with DSA colors before when applied to backgrounds or text in some instances, when the colors for the text and color around the text should be sort of distinct from the DSA color usage. @bmos has laid out some good tasks dividing up the issues.

Im ready to start making PR's on this to get it started, and then I will be able to happily show anyone about the tools I use for testing that are going to guide the process I take . I may need some permissions to push up branches, or should I do this from a fork? I got a 403 when I tried to push up a branch @colinmahns

@bmos
Copy link
Author

bmos commented Mar 13, 2024

Wow, what a great team 😃

I'll see if we can get you both added to the dsa-planet team so you have permissions. I messaged Colin on the forum and see Morgan has mentioned him here.

So great to have the person who worked on the original implementation here, @victoria-riley-barnett.

Thank you @airbr for sharing those (much better) validation tools, your expertise with web accessibility is greatly appreciated.

It was really cool pulling down all the blog posts and looking at them.

Isn't it? Seeing all that DSA history coming in is a great pick-me-up.

I went back to the first post and updated the tasks with some links to the relevant files to save time looking for the right bits.

How do we want to spread out this work? The parts that seem most in line with my familiarity are adding alt-text to the avatars and applying programmatic changes to downloaded feed content (if we can integrate it in a more accessible manner -- likely will have questions about best practices for this).

Would it make sense to break out this issue into smaller issues for each task and, if so, are there missing tasks or should they be restructured at all?

@airbr
Copy link

airbr commented Mar 14, 2024

@bmos I think Im going to try and fix the Headings order of DSA Planet, and fix the a tag around the logo. Then ideally I will make some very basic changes to improve color contrast on some of the text. Im just working on a branch :)

@bmos
Copy link
Author

bmos commented Mar 16, 2024

I have added basic programmatic alt text to the avatars and totally rebuilt the showmore/less buttons using javascript so they could use the native button tag which is usable via keyboard navigation.

@bmos
Copy link
Author

bmos commented Mar 22, 2024

@colinmahns is away but @ce-warren has added you, @airbr.

@airbr
Copy link

airbr commented Mar 22, 2024

Thank you ! I'll get a chance to take a look at this soon

@airbr
Copy link

airbr commented Apr 14, 2024

@bmos I created #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants