Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Rewrite #52

Closed
9 tasks done
drweissbrot opened this issue May 27, 2023 · 0 comments · Fixed by #53
Closed
9 tasks done

v2: Rewrite #52

drweissbrot opened this issue May 27, 2023 · 0 comments · Fixed by #53
Assignees

Comments

@drweissbrot
Copy link
Owner

drweissbrot commented May 27, 2023

  • Players Alive panel
  • Focused Player panel
  • Top Bar
  • "Series Name" panel
  • Radar
  • Sidebars
  • Series and Round Graph panel
  • Make sure everything that reasonably should is a CSS variable, and components, methods, etc. are reasonably split up
  • Cleanup

I've learned a couple things since I originally started building this. Some design decisions were, in hindsight, not great; usually because the original target audience of this was only myself. But since there is at least one other person using this who currently has to live with my shoddy code, and with CS2 coming at us any decade now, I think now's as good a time as any to restart this project from scratch, and replace the old bad design decisions with new, hopefully-less-bad design decisions.

Primary goals:

  • CS2 support
    For now, this means preparing everything to eventually work with CS2, i.e. decoupling the "data layer" from the raw GSI payloads. There's currently no demo viewer, no GOTV, and no GSI in the Limited Test. I'm assuming all of these will return; if they don't, I think it may be possible to write a LUA addon or something to mimic GSI.
  • Easier customization
    Judging from the forks of this repo, most users of this HUD are fine with the general look, but want to apply their own color scheme. This should be easy to do, without having to fork the repo (and in turn, making updates more difficult). Heavier customization should be possible too, also without having to fork. In general, forks should be for bug fixes and feature additions, not for customization.
  • Easier extensibility
    There are a couple features I and other users would like that are currently very hard/annoying to implement because the code was not written with extensibility or maintainability in mind.
  • OBS Browser Source
    Likely a better approach than the current "Fullscreen Windowed plus Display Capture" flow.

Additionally, I'd like to eventually have prepackaged exectuables with update checking (#60), container images (#61), docs + changelog (#59), and a landing page to showcase the project (#62).

For this Issue, the goal is a functioning MVP, that looks similar to the current version, supports the primary customization features, and is accessible as a web page.

@drweissbrot drweissbrot self-assigned this May 27, 2023
drweissbrot added a commit that referenced this issue May 28, 2023
yeah i know "commits should do one thing" i dont car
drweissbrot added a commit that referenced this issue May 28, 2023
drweissbrot added a commit that referenced this issue May 28, 2023
drweissbrot added a commit that referenced this issue May 28, 2023
drweissbrot added a commit that referenced this issue May 28, 2023
these are ripped from the game files, and minified via SVGOMG/SVGO
drweissbrot added a commit that referenced this issue May 28, 2023
drweissbrot added a commit that referenced this issue May 28, 2023
drweissbrot added a commit that referenced this issue May 28, 2023
@drweissbrot drweissbrot linked a pull request May 28, 2023 that will close this issue
drweissbrot added a commit that referenced this issue May 29, 2023
drweissbrot added a commit that referenced this issue May 30, 2023
turns out OBS currently uses Chromium 103, which is about a year too old for nested CSS support :(
@drweissbrot drweissbrot pinned this issue May 30, 2023
drweissbrot added a commit that referenced this issue Jun 2, 2023
drweissbrot added a commit that referenced this issue Jun 4, 2023
Noto Sans specifically because it supports like, every language
drweissbrot added a commit that referenced this issue Jun 9, 2023
drweissbrot added a commit that referenced this issue Jun 9, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
it's more difficult to work around some issues than it's annoying to just say "booleans always have to be false by default"
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jun 18, 2023
drweissbrot added a commit that referenced this issue Jul 28, 2023
@drweissbrot drweissbrot unpinned this issue Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant