-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support iOS #36
Comments
A first step towards compilation on iOS can be found in the Start compilation with |
Great! If you would like to make a PR for those changes, I would be delighted to pull it. Quick note on the author tag. I just stripped those because they are something which Anthony Cros did and which we didn't really talk through at the time. I don't think that per-file author tags are at all useful. See a0c9df0 So please could you NOT add an author line in your edit? See also https://bobsummerwill.com/2016/07/12/ethereum-everywhere/ and https://bobsummerwill.com/2016/07/12/c-re-licensing-plan/ which I am working through for cpp-ethereum right now. We're already using Apache 2.0 for cpp-ethereum-cross (which is "my thing" unrelated to my work at the Ethereum Foundation), so there is nothing TODO there, but be aware that I am likely going to want to work through similar paperwork for cpp-ethereum-cross - which would just be a simple doc declaring that the contributions came from the contributor. I would want to do that because I think that cpp-ethereum-cross is likely to be donated to a larger project at some stage soon. Just want to check that you are cool with that coming your way if you contribute here? :-) |
Will be something just like this: |
Yes, I'm fine with using the apache license and signing the individual contributor license agreement. |
Great - so yes, please free to create a PR for this iOS support, and we can get into a pattern of you doing some chunk of work, me reviewing/sucking in, and round we go. No doubt we will have working iOS binaries in no time. I can also looking in what @karalabe did for his iOS cross-builds, and maybe I can mimic that here too, so that I can have my TravisCI runs producing iOS binaries too (even if they are slightly crappy ones). |
There are standard APT packages for Android cross-compilers just like the ARM cross-compilers which I have here already, so I think that adding Android binaries here too will be easy. That has also just been sitting on my backlog forever, un-actioned because of other priorities. |
Aside - I was just cleaning up what I thought was old and unused content in the Releases of this repos and deleted "ExternalDependencies". Looks like the scripts DO actually reference that location, for the Boost ZIP: https://github.com/doublethinkco/cpp-ethereum-cross/blob/master/cross-build/ethereum/setup.sh#L47 So you might find yourself temporary broken, but that was literally just the Boost 1.61.00 I also have forked cryptopp, jsoncpp and libjson-rpc-cpp repos within doublethinkco. I think they were all tiny edits to add There is still a long list of minor hacks to be upstreamed/resolved/removed: And as I am working on the upstream, I am in a great place to make those happen :-) I understand the cpp-ethereum build system much better than I did when these scripts were written by Anthony, at which stage we were both total noobs and outsiders to cpp-ethereum. |
As soon as I have landed cpp-ethereum back into ethereum/cpp-ethereum and made the v1.3.1 release, I will refocus on eliminating all these hacks, and simplifying these scripts again. I will probably roll them all together into main.sh, and look to combine the multiple CMake ones into a single multi-output pass, if I can. All the homogenization is unnecessary, for example. That can all go. |
I think that all the "install" steps can likely be eliminated too. |
No description provided.
The text was updated successfully, but these errors were encountered: