Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git sub-modules for external dependencies as much as possible #17

Closed
anthony-cros opened this issue Nov 18, 2015 · 6 comments
Closed

Comments

@anthony-cros
Copy link
Member

No description provided.

@bobsummerwill
Copy link
Member

Are you talking about the proposal to use git sub-modules for external dependencies too? Rather than WGETs of random ZIPs? @anthony-cros

@anthony-cros
Copy link
Member Author

yes, exactly, to avoid (hopefully) the kind of issues we've had with MPFR and CRYPTOPP binaries! hopefully they all use a github or similar

@bobsummerwill
Copy link
Member

Right, so in "best" to "OK" order, we would ...

  1. Just use sub-module for the release branch in an existing github repo which is exactly the same as the ZIPs, if such exists.
  2. Or some of them have mirrors which somebody has made other than the team themselves. If those have the same content then we would go with that instead. We're not guaranteed them will be maintained to the same degree, and they may become a burden in the future, but it saves us some work for now.
  3. Worst-case we just un-ZIP the versions we need into our own doublethinkco/ and reference those as sub-modules.

@anthony-cros
Copy link
Member Author

yes, though from what i've seen most seemed to meet (1)! cryptopp might not, but it won't be around much much longer i think

@bobsummerwill bobsummerwill changed the title eth scripts: bundles dependencies' sources - all listed dependencies in the Dockerfile to be included Use git sub-modules for external dependencies as much as possible Nov 26, 2015
@bobsummerwill bobsummerwill removed the eth label Nov 28, 2015
@bobsummerwill
Copy link
Member

See #46 and #47.

@bobsummerwill
Copy link
Member

Covered just fine with #46 and #47. Deleting this which is now just a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants