Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build break - armel - invalid use of incomplete type 'class std::future<void> #111

Open
bobsummerwill opened this issue Aug 26, 2016 · 2 comments
Assignees
Labels

Comments

@bobsummerwill
Copy link
Member

bobsummerwill commented Aug 26, 2016

�[0m[ 75%] /home/crosseth/eth/wd/cpp-ethereum/test/libethereum/test/TestHelper.cpp: In function 'void dev::test::testMiningFunc(void (*)())':
/home/crosseth/eth/wd/cpp-ethereum/test/libethereum/test/TestHelper.cpp:1101:79: error: invalid use of incomplete type 'class std::future<void>'
   auto future = std::async(std::launch::async, &std::thread::join, &threadTest);
                                                                               ^

Looks like it's an issue with the use of std::future on this particular architecture.

This is brand new code from @winsvega for adding the dots to keep TravisCI alive, which is obviously constraining portability. We should probably do something simpler with std::thread instead.

This particular error log is for the armel cross-build (armv5) but it looks like there are probably more.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735

@bobsummerwill bobsummerwill self-assigned this Aug 26, 2016
@bobsummerwill
Copy link
Member Author

One of the two instances of this has been removed upstream (mining timeouts).

The other (the dots) remains for now, but we'll look at this too.

@bobsummerwill
Copy link
Member Author

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735

Was fixed in 2017, so this might not be an issue anymore, if the GCC within the Docker image was updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant