Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the ability to stop when a specified string has been generated #417

Closed
rlouf opened this issue Dec 8, 2023 · 2 comments · Fixed by #451
Closed

Restore the ability to stop when a specified string has been generated #417

rlouf opened this issue Dec 8, 2023 · 2 comments · Fixed by #451
Labels
enhancement help wanted

Comments

@rlouf
Copy link
Member

rlouf commented Dec 8, 2023

This was removed in #366 to simplify the PR. It should be simple to implement it at the SequenceGenerator level.
@RobinPicard
Copy link
Contributor

I see how we could check whether all sequences contain the stop characters after last_state = next(states) in SequenceGenerator.__call__ but I can't find a way of ending the generation for a particular sequence if this one includes the stop characters (but not the others) without modifying the sequence_generator function. Do you have a solution in mind?

@rlouf rlouf mentioned this issue Dec 14, 2023
Closed
@rlouf
Copy link
Member Author

rlouf commented Dec 19, 2023

Can't we do this at the SequenceGenerator level?

@RobinPicard RobinPicard mentioned this issue Dec 20, 2023
Merged
@rlouf rlouf linked a pull request Dec 20, 2023 that will close this issue
Restore the ability to stop when a specified string has been generated #451
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore the ability to stop when a specified string has been generated RobinPicard/outlines
2 participants
@rlouf @RobinPicard