Add String.Replace() method overloads to accept String Arrays

[vsfeedback]

This issue has been moved from a ticket on Developer Community.

---

I’d suggest adding 2 overloads for the String.Replace() method to accept string arrays.

1. Suggestion: String.Replace(String[], String[])

This will replace all occurences from the first argument (String[]) with the second argument (String[]).
Example:

var testString = "this is just a test";
string[] search = { "this", "just", "test" };
string[] replace = { "that", "only", "plane" };
var newString = testString.Replace(search, replace); // "that is only a plane"

At the moment you could call 3x Replace() in a chain to achieve this or write a new method for that with a loop etc.

2. Suggestion: String.Replace(String[], String)

This will replace all occurences from the first argument (String[]) with the second argument (String)
Example:

var testString = "this is just a test";
string[] search = { "this", "test" };
string replace = "no";
var newString = testString.Replace(search, replace); // "no is just a no"

---

Original Comments

Feedback Bot on 7/1/2020, 01:33 AM:

Thank you for taking the time to provide your suggestion.  We will do some preliminary checks to make sure we can proceed further.  We'll provide an update once the issue has been triaged by the product team.

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[Gnbrkm41]

Related: #29249.

Personally not a great fan of the fact that replacements happen based on the index of the item.... I personally prefer the tuple approach described in #29249.

The second one... Not sure, one use could have been for normalising line breaks, but for that the better version of it is suggested in #40315. Not sure what other use cases might exist.

[Zerotask]

Personally not a great fan of the fact that replacements happen based on the index of the item

It would be the value, not the index.
Tuples would be an option, too. I think you have more string arrays than tuples usually, e. g. a list from a JSON file or a column from a database table. So accepting a string array would be a better solution. Although I'm not against your suggestion. As you said, that is a personal preference.

Not sure what other use cases might exist.

There are many use cases for it. I haven't thought about line breaks instead I thought about filters, e. g. a bad word filter where you have a string array with words you don't want to have in the target string and which will be replaced to something like <bad word>. A specific example would be a stream bot (e. g. for Twitch).