Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly-typed database schema API that doesn't rely on DataTable #19324

Closed
roji opened this issue Nov 10, 2016 · 6 comments
Closed

Strongly-typed database schema API that doesn't rely on DataTable #19324

roji opened this issue Nov 10, 2016 · 6 comments
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Data backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity

Comments

@roji
Copy link
Member

roji commented Nov 10, 2016

The current API to expose database schema is DbConnection.GetSchema(). This has some disadvantages:

  • Reliance on DataTable
  • A weakly-typed API. Aside from being less usable, this promotes less uniformity across providers as different weakly-typed properties can be populated.

A modern, strongly-typed resultset schema API has already been added - DbDataReader.GetColumnSchema() effectively replaces DbDataReader.GetSchema() which suffers from the same shortcomings as DbConnection.GetSchema().

See #15953 for previous discussion.

@karelz
Copy link
Member

karelz commented Nov 10, 2016

We need formal API proposal. We expect it will be rather complex.

@roji
Copy link
Member Author

roji commented Nov 12, 2016

Note the substantial previous discussion in #15953 which should be taken into account. The existing weakly-typed DataTable-based API can definitely serve as a starting point, but this is definitely the opportunity to clearly separate common metadata from SQL Server-centric metadata etc.

@karelz
Copy link
Member

karelz commented Nov 12, 2016

@roji do you plan to create the proposal?

@roji
Copy link
Member Author

roji commented Nov 12, 2016

Well, @saurabh500 made a good start in #15953, it's worth pursuing that with the community. I'm not going to have the time to lead the discussion, although I'd be happy to review/contribute.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, Future Jun 23, 2020
@ajcvickers ajcvickers removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2020
Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Dec 23, 2024
Copy link
Contributor

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@dotnet-policy-service dotnet-policy-service bot removed this from the Future milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Data backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Projects
None yet
Development

No branches or pull requests

5 participants