Log glob failures #11211
Merged
Log glob failures #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good, I have several nit comments and a point for discussion for the tuple usage. |
YuliiaKovalova
approved these changes
Jan 3, 2025
maridematte
reviewed
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9609
Context
Logging when glob expansions fail is useful for debugging.
Log it quietly (as a message with low priority).
Changes Made
FileMatcher.GetFiles returns a message if an exception occurs when matching files, it's callers log it.
Testing
Covered by existing tests.
Failures which would be logged are rare.
Tested manually triggering an exception in the critical section and the message displays in binlog:
Notes
Figuring out how to log is a bit tricky with some of the code being in static, some in singleton contexts and there are multiple logging mechanisms.