Rate limitter sample bug/clarification

[validide]

Hi,

While looking over the reate limitter documentatin I was looking at the following code sample:

    _.OnRejected = (context, _) =>
    {
        if (context.Lease.TryGetMetadata(MetadataName.RetryAfter, out var retryAfter))
        {
            context.HttpContext.Response.Headers.RetryAfter =
                ((int) retryAfter.TotalSeconds).ToString(NumberFormatInfo.InvariantInfo);
        }

        context.HttpContext.Response.StatusCode = StatusCodes.Status429TooManyRequests;
        context.HttpContext.Response.WriteAsync("Too many requests. Please try again later.");

        return new ValueTask();
    };

Is the WriteAsync method call missing the await by design? At first glance this seems as a bug.

[Rick-Anderson]

@Kahbazi @maartenba should we change that to WriteAsync

[maartenba]

Good idea - this indeed should be sync (or use await but I'd vote using the sync version here)

[Kahbazi]

@Kahbazi @maartenba should we change that to WriteAsync

I think it's better to keep the async and add await before it.