Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency upon Firebase Public community builder images #309

Open
jessegduke opened this issue Jul 20, 2023 · 1 comment
Open

Remove dependency upon Firebase Public community builder images #309

jessegduke opened this issue Jul 20, 2023 · 1 comment
Labels
refactor Refactor for maintainability

Comments

@jessegduke
Copy link
Collaborator

Currently, deployment requires a Firebase builder for Cloud Build. We use the public community builder. Therefore, it must be built and pushed into the project's Container Registry repo.

A more dynamic approach would be to convert to installation on demand for firebase (and Hugo). See preview-infra.cloudbuild.yaml id: 'Firebase (re)Deploy All' as an example

Updates include:

ci/README.md (Updates to doc)
ci/preview-content.cloudbuild.yaml
ci/cloudbuild.yaml

Clean-up of legacy images
@jessegduke
Copy link
Collaborator Author

@davidstanke - Are you still interested in this refactor? If so, I will target this for next refactor effort.

@davidstanke davidstanke mentioned this issue Jan 12, 2024
Closed
@nathenharvey nathenharvey added the refactor Refactor for maintainability label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor for maintainability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathenharvey @jessegduke