Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rewrite table data when changing enum/varchar/varbinary type to make it more permissive. #8865

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nicktobey
Copy link
Contributor

@nicktobey nicktobey commented Feb 16, 2025

Sometimes a schema change can widen the set of valid column values without affecting the representation of any existing columns. Examples include:

  • Adding a possible value to the end of an enum
  • Increasing the length of a varchar/varbinary column.

In these cases, there's no need to rewrite the table, since every tuple is guaranteed to have the same representation it had before.

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1772eac ok 5937457
version total_tests
1772eac 5937457
correctness_percentage
100.0

@nicktobey nicktobey changed the title Don't rewrite table data when changing enum type in a compatible way. Don't rewrite table data when changing enum/varchar/varbinary type to make it more permissive. Feb 17, 2025
@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e6a8ab1 ok 5937457
version total_tests
e6a8ab1 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
51969e8 ok 5937457
version total_tests
51969e8 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
97ddfde ok 5937457
version total_tests
97ddfde 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3126479 ok 5937457
version total_tests
3126479 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
10e558d ok 5937457
version total_tests
10e558d 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
021a883 ok 5937457
version total_tests
021a883 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
997bfef ok 5937457
version total_tests
997bfef 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d3aaf30 ok 5937457
version total_tests
d3aaf30 5937457
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants