Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace min/max helpers with built-in min/max #8726

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Replace min/max helpers with built-in min/max #8726

merged 1 commit into from
Jan 9, 2025

Conversation

macneale4
Copy link
Contributor

We can use the built-in min and max functions since Go 1.21.

Reference: https://go.dev/ref/spec#Min_and_max

@Juneezee
Replace min/max helpers with built-in min/max
0515265 
We can use the built-in `min` and `max` functions since Go 1.21.

Reference: https://go.dev/ref/spec#Min_and_max
Signed-off-by: Eng Zer Jun <[email protected]>
@macneale4 macneale4 mentioned this pull request Jan 9, 2025
Merged
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0515265 ok 5937457
version total_tests
0515265 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit 0cbfe0e into main Jan 9, 2025
53 of 56 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macneale4 @coffeegoddd @Juneezee