[statspro] Bootstrap database statistics once on startup #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@max-hoffman DOLT
|
max-hoffman
force-pushed
the
max/stats-bootstrap
branch
from
279044b to
2fb4d54
Compare
|
@max-hoffman DOLT
|
|
@coffeegoddd DOLT
|
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
zachmu
approved these changes
Jun 21, 2024
| @@ -134,6 +168,9 @@ func (p *Provider) RefreshTableStats(ctx *sql.Context, table sql.Table, db strin | |||
| // branchQualifiedDatabase returns a branch qualified database. If the database | |||
| // is already branch suffixed no duplication is applied. | |||
| func (p *Provider) branchQualifiedDatabase(db, branch string) string { | |||
| if branch == "" { | |||
There was a problem hiding this comment.
Probably better to do this at the call site
|
I benchmarked the startup cost for this, and it seems like a similar penalty to rebuilding a journal index. Testing on a 50 million row database, startup without stats is 1.5 minutes, with stats after bootstrapping is about 3 minutes, first bootstrap is 20 minutes. |
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load database statistics once on sql engine startup. If auto refresh is enabled, bootstrap is not performed. Behavior is on by default and can be turned off:
(calling the command above with non-empty tables will still bootstrap statistics once)
This includes a small change to the way we encode column types for stats. We previously split using a comma
",", but enums and others can include commas so we use a line break now"/n". Old versions of stats will fail to load with the newer version.