Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] getDerivedHDAddress returns a serialized key #217

Open
chromatic opened this issue Jun 9, 2024 · 5 comments
Open

[bug] getDerivedHDAddress returns a serialized key #217

chromatic opened this issue Jun 9, 2024 · 5 comments

Comments

@chromatic
Copy link
Contributor

Bug Report

Current behavior:

In at least version 0.1.3 and the branch for 0.1.4, getDerivedHDAddress() returns a key, not an address (returning the output of getDerivedHDKeyByPath.

Expected behavior

I'd like to receive an address instead.

@edtubbs
Copy link
Collaborator

edtubbs commented Jun 9, 2024

Agreed, I think this is the original commit: 9e4d7a6.

With derive_bip44_extended_key you can extend to any level and then use dogecoin_hdnode_get_p2pkh_address to generate addresses.

@chromatic
Copy link
Contributor Author

I can work around that in 0.1.3 now--can I rely on that version of the library providing those two functions you mentioned as stable and accessible?

@edtubbs
Copy link
Collaborator

edtubbs commented Jun 9, 2024

Yes, both are in libdogecoin.h 0.1.3, in example and bip44_tests.

@chromatic
Copy link
Contributor Author

I've pushed a new branch on my wrapper repository. If anyone reading this has the time and inclination to review the behavior, I welcome comments.

https://github.com/chromatic/Finance-libdogecoin/tree/libdogecoin-0.1.3-dev

chromatic added a commit to chromatic/libdogecoin that referenced this issue Jun 10, 2024
chromatic added a commit to chromatic/libdogecoin that referenced this issue Jun 11, 2024
@xanimo
Copy link
Member

xanimo commented Aug 27, 2024

I've pushed a new branch on my wrapper repository. If anyone reading this has the time and inclination to review the behavior, I welcome comments.

https://github.com/chromatic/Finance-libdogecoin/tree/libdogecoin-0.1.3-dev

i don't know perl but as far as i can tell it looks proper. was there an issue with the work around @edtubbs suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants