Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query::iterate not marked as deprecated #8387

Closed
simonberger opened this issue Dec 9, 2020 · 0 comments · Fixed by #8467
Closed

Query::iterate not marked as deprecated #8387

simonberger opened this issue Dec 9, 2020 · 0 comments · Fixed by #8467
Milestone
2.8.2

Comments

@simonberger
Copy link
Contributor

Just a minor missing deprecation annotation in 2.7 and 2.8.
AbstractQuery::iterate is marked as deprecated but Query::iterate isn't.
It still triggers a message through its parent call.
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 8, 2021
@beberlei
[doctrineGH-8387] Missing @deprecated on Query::iterate
094453c
@beberlei beberlei mentioned this issue Feb 8, 2021
Merged
@beberlei beberlei added this to the 2.8.2 milestone Feb 8, 2021
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 16, 2021
@beberlei
[doctrineGH-8387] Missing @deprecated on Query::iterate
b5f740c
beberlei added a commit that referenced this issue Feb 16, 2021
@beberlei
[GH-8410] Fix memory leak in new toIterable and state bug. (#8467)
30a7c2a 
* [GH-8410] Fix memory leak in new toIterable and state bug.

The new AbstractQuery::toIterable() had a memory leak that
AbstractQuery::iterable() did not have. This leak is now fixed.

After fixing the leak, one test failed where the identity map in
ObjectHydrator triggered and lead to a notice. Introduced a new
AbstractHydrator::cleanupAfterRowIteration() that the ObjectHydrator
uses to cleanup the state.

* [GH-8413] Bugfix: Iterating with multiple, mixed results

When multiple entity results are part of a row, the result handling
must be different. In addition mixed results with scalars are broken
and now throw an exception as illegal operation.

* Housekeeping: phpcs

* [GH-8413] Add assertions for entity alias iteration.

* [GH-8387] Missing @deprecated on Query::iterate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.2
Development

Successfully merging a pull request may close this issue.

[GH-8410] Fix memory leak in new toIterable and state bug. beberlei/doctrine2
2 participants
@beberlei @simonberger