From 21d2c880136a858a9ab3673fdd78fb920dd792fa Mon Sep 17 00:00:00 2001 From: Benjamin Eberlei Date: Sun, 6 Dec 2020 22:00:00 +0100 Subject: [PATCH] [GH-7486] Bugfix: failing the command when clearing empty cache is wrong semantics. (#8376) --- .../Tools/Console/Command/ClearCache/MetadataCommand.php | 6 ------ .../ORM/Tools/Console/Command/ClearCache/QueryCommand.php | 6 ------ .../ORM/Tools/Console/Command/ClearCache/ResultCommand.php | 6 ------ 3 files changed, 18 deletions(-) diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php index e6531f22212..56472662199 100644 --- a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php +++ b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php @@ -99,12 +99,6 @@ protected function execute(InputInterface $input, OutputInterface $output) $message = ($result) ? 'Successfully flushed cache entries.' : $message; } - if ( ! $result) { - $ui->error($message); - - return 1; - } - $ui->success($message); return 0; diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php index 95bec91de8d..5345091248e 100644 --- a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php +++ b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php @@ -98,12 +98,6 @@ protected function execute(InputInterface $input, OutputInterface $output) $message = ($result) ? 'Successfully flushed cache entries.' : $message; } - if ( ! $result) { - $ui->error($message); - - return 1; - } - $ui->success($message); return 0; diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php index 42ad79c502c..714dacacd24 100644 --- a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php +++ b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php @@ -99,12 +99,6 @@ protected function execute(InputInterface $input, OutputInterface $output) $message = ($result) ? 'Successfully flushed cache entries.' : $message; } - if ( ! $result) { - $ui->error($message); - - return 1; - } - $ui->success($message); return 0;