-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to display the result set #110
Comments
@beberlei this would require some logging in the ORM. Currently, we only have logging at the DBAL level |
Why in the ORM? |
@schmittjoh because there is no result set mapping in the DBAL. Or do you mean displaying the result of running the query itself ? This would make things pretty big in the profiler. |
I meant the raw results. On Fri, Sep 7, 2012 at 2:26 PM, Christophe Coevoet <[email protected]
|
I see some cases where it might be useful, but I don't see a good way to display them in a readable way when the query returns lots of results. |
👍 Wouldn't this also allow to display DQL in the profiler section? I think this would be a great improvement for readability in this section. |
@bamarni if we have logging in the needed places in the ORM, it could. However, I think it would be confusing to display both the DQL and the SQL in the profiler (we cannot remove SQL as DQL is not always used). But see #109 for a feature requiring the logging in the ORM, as this one does not in fact. |
@stof: maybe there could be a button to switch from SQL to DQL (if available)? I was not saying to remove the SQL. But DQL can be useful when you just want to get an overview of a query. |
@bamarni the SQL is logged at the DBAL level. There is no DQL here. And for all queries dones because of the lazy-loading or a findBy call, there is no DQL at all. Anyway, please create a dedicated issue if you want to discuss it as this is not related to showing the results |
Hi, is this still relevant? By the looks of the discussion it seems that displaying the results isn't really needed and to be honest, there are plenty of dedicated tools that can run SQL queries, like PHPMyAdmin for example. |
For now i rather want to avoid, if a good PR comes up i may reconsider. |
Currently, you can "EXPLAIN" queries in the profiler. It would also be nice if you could let it display the result set of the query in the profiler.
The text was updated successfully, but these errors were encountered: