Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper function for declaring rule lists. #12

Open
bddap opened this issue Mar 9, 2021 · 0 comments
Open

Helper function for declaring rule lists. #12

bddap opened this issue Mar 9, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@bddap
Copy link
Contributor

bddap commented Mar 9, 2021

Context: https://github.com/docknetwork/rify/pull/10/files/2eec95882bf018c3678f1f168be2fd3192bb76f3#r590589241

The function decl_rules is declared but only exposed to unit tests. Users could benefit from a public version.

The public version shouldn't panic. Instead it should return a Result.
@bddap bddap added the good first issue Good for newcomers label Mar 9, 2021
@bddap bddap mentioned this issue Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bddap