From 2870ce8b1595a24b84282cd646a9156c4b4ec09b Mon Sep 17 00:00:00 2001 From: Slaven Bacic Date: Sat, 23 Jul 2016 07:49:29 +0200 Subject: [PATCH 1/2] Add fixes and lintian overrides to electron-installer-debian, with comments. Signed-off-by: Slaven Bacic --- Gruntfile.js | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index f0a2cdaeb..48a6bd732 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -317,15 +317,36 @@ module.exports = function (grunt) { }, 'electron-installer-debian': { options: { - productName: LINUX_APPNAME, + name: BASENAME.toLowerCase(), // spaces and brackets cause linting errors + productName: LINUX_APPNAME.toLowerCase(), productDescription: 'Run containers through a simple, yet powerful graphical user interface.', + maintainer: 'Ben French ', section: 'devel', priority: 'optional', icon: './util/kitematic.png', lintianOverrides: [ 'changelog-file-missing-in-native-package', 'executable-not-elf-or-script', - 'extra-license-file' + 'extra-license-file', + //File permission overrides + 'non-standard-dir-perm', + 'non-standard-file-perm', + 'non-standard-executable-perm', + 'script-not-executable', + 'shlib-with-executable-bit', + + 'binary-without-manpage', //Kitematic does not have a manpage + + 'debian-changelog-file-missing', //incorrectly reports the debian changelog file as missing (probably looking in the wrong place) + 'unusual-interpreter', //node does not appear as a "known" interpreter to lintian + 'wrong-path-for-interpreter', //certain node_modules have hardcoded paths rather than using #!/usr/bin/env NAME + 'backup-file-in-package', //node_modules contain README.md~, probably from npm packing + 'package-contains-vcs-control-file', //node_modules contain .git folders, again, probably left over from npm packing + + 'embedded-javascript-library', //I'm assuming that JS libs are embedded intentionally into the Kitematic release + 'embedded-library', //Ditto for embedded libaries like libnode and libgcrypt + 'arch-dependent-file-in-usr-share' //for architecture (amd64 vs i386) specific .so libraries + ], categories: [ 'Utility' From 5a18d0e1c3df9e27033479572103e985b24bfb77 Mon Sep 17 00:00:00 2001 From: Slaven Bacic Date: Sat, 23 Jul 2016 07:50:55 +0200 Subject: [PATCH 2/2] Removed comments and collapsed overrides. Signed-off-by: Slaven Bacic --- Gruntfile.js | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 48a6bd732..27692ee88 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -328,25 +328,20 @@ module.exports = function (grunt) { 'changelog-file-missing-in-native-package', 'executable-not-elf-or-script', 'extra-license-file', - //File permission overrides 'non-standard-dir-perm', 'non-standard-file-perm', 'non-standard-executable-perm', 'script-not-executable', 'shlib-with-executable-bit', - - 'binary-without-manpage', //Kitematic does not have a manpage - - 'debian-changelog-file-missing', //incorrectly reports the debian changelog file as missing (probably looking in the wrong place) - 'unusual-interpreter', //node does not appear as a "known" interpreter to lintian - 'wrong-path-for-interpreter', //certain node_modules have hardcoded paths rather than using #!/usr/bin/env NAME - 'backup-file-in-package', //node_modules contain README.md~, probably from npm packing - 'package-contains-vcs-control-file', //node_modules contain .git folders, again, probably left over from npm packing - - 'embedded-javascript-library', //I'm assuming that JS libs are embedded intentionally into the Kitematic release - 'embedded-library', //Ditto for embedded libaries like libnode and libgcrypt - 'arch-dependent-file-in-usr-share' //for architecture (amd64 vs i386) specific .so libraries - + 'binary-without-manpage', + 'debian-changelog-file-missing', + 'unusual-interpreter', + 'wrong-path-for-interpreter', + 'backup-file-in-package', + 'package-contains-vcs-control-file', + 'embedded-javascript-library', + 'embedded-library', + 'arch-dependent-file-in-usr-share' ], categories: [ 'Utility'