From 59dd071d7ea10f6dccec4cd766275d50c32b9ef2 Mon Sep 17 00:00:00 2001 From: jinmfeng Date: Tue, 15 Aug 2023 16:13:20 +0800 Subject: [PATCH] Fix bug that cause stage data loss due to internal closures and unreasonable cache settings during retry --- .../scala/ml/dmlc/xgboost4j/scala/spark/PreXGBoost.scala | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/PreXGBoost.scala b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/PreXGBoost.scala index 31d58224b108..548f8b5adda4 100644 --- a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/PreXGBoost.scala +++ b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/PreXGBoost.scala @@ -379,7 +379,7 @@ object PreXGBoost extends PreXGBoostProvider { xgbExecutionParam.allowNonZeroForMissing), getCacheDirName(xgbExecutionParam.useExternalMemory)) Iterator.single(buildWatches) - }).cache() + }) } else { coPartitionGroupSets(trainingData, evalSetsMap, xgbExecutionParam.numWorkers).mapPartitions( labeledPointGroupSets => { @@ -390,7 +390,7 @@ object PreXGBoost extends PreXGBoostProvider { }, getCacheDirName(xgbExecutionParam.useExternalMemory)) Iterator.single(buildWatches) - }).cache() + }) } } @@ -467,7 +467,7 @@ object PreXGBoost extends PreXGBoostProvider { xgbExecutionParams.allowNonZeroForMissing), getCacheDirName(xgbExecutionParams.useExternalMemory)) Iterator.single(buildWatches) - }}.cache() + }} } else { coPartitionNoGroupSets(trainingData, evalSetsMap, xgbExecutionParams.numWorkers). mapPartitions { @@ -479,7 +479,7 @@ object PreXGBoost extends PreXGBoostProvider { }, getCacheDirName(xgbExecutionParams.useExternalMemory)) Iterator.single(buildWatches) - }.cache() + } } }