Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache bind group layouts before specializing pipelines #388

Open
djeedai opened this issue Oct 23, 2024 · 0 comments
Open

Cache bind group layouts before specializing pipelines #388

djeedai opened this issue Oct 23, 2024 · 0 comments
Labels
A - internal Internal change on a core system C - enhancement New feature or request

Comments

@djeedai
Copy link
Owner

djeedai commented Oct 23, 2024

We create bind group layouts during pipeline specialization because we need them, but then discard them (because we can't mutate anything inside specialize()), and then re-create a second exact copy of the layout layer when we need to cache it to be able to later create the bind group. This is a source of errors, and a waste of GPU memory. We should create and cache those layouts once and for all before we specialize the pipeline, and use the same object for the pipeline specialization and for the bind group creation.

@djeedai djeedai added C - enhancement New feature or request A - internal Internal change on a core system labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - internal Internal change on a core system C - enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant