Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse Move Event is triggering Change Detection #145

Open
uap-universe opened this issue Oct 24, 2023 · 1 comment
Open

Mouse Move Event is triggering Change Detection #145

uap-universe opened this issue Oct 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@uap-universe
Copy link
Collaborator

uap-universe commented Oct 24, 2023

When the column resize function was implemented, some mouse listeners were registered to detect the click and drag events for the column separator.

Unfortunately, what nobody noticed, that mouse listeners are causing high frequent change detection runs when you just move your mouse over the area of the table.

This has high performance impact and is most likely one of the reasons why notebooks start their rocket engines when opening a page containing a smart table.

@uap-universe uap-universe added the bug Something isn't working label Oct 24, 2023
@uap-universe uap-universe added this to the 3.1.0 milestone Oct 25, 2023
@uap-universe uap-universe self-assigned this Oct 25, 2023
@uap-universe uap-universe removed this from the 3.1.0 milestone Oct 25, 2023
@uap-universe
Copy link
Collaborator Author

I did some research, but "the internet says" that this behavior from the HostListener is by design.

That means, probably, the whole thing would need a major overhaul to be fixed.

The unfortunate thing about it is, that the user is paying the costs even when column resizing is completely deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant