From 35a7d768022a9f493b26468d8f303191445052b0 Mon Sep 17 00:00:00 2001 From: Dave Viggiano Date: Mon, 29 Jan 2024 09:35:19 -0500 Subject: [PATCH 1/6] Removed an obsolete comment (creating branch for connect_qa). --- app/src/org/commcare/activities/LoginActivity.java | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/org/commcare/activities/LoginActivity.java b/app/src/org/commcare/activities/LoginActivity.java index 25720b6897..df0c47489d 100644 --- a/app/src/org/commcare/activities/LoginActivity.java +++ b/app/src/org/commcare/activities/LoginActivity.java @@ -364,7 +364,6 @@ private boolean forceAutoLogin() { private String getUniformUsername() { String username = uiController.getEnteredUsername(); if (ConnectManager.isUnlocked() && appLaunchedFromConnect) { - //Configure some things if we haven't already username = ConnectManager.getUser(this).getUserId(); } return username.toLowerCase().trim(); From 6caf3cf31646e07305076926b44dfbbbf4170487 Mon Sep 17 00:00:00 2001 From: Dave Viggiano Date: Tue, 30 Jan 2024 09:04:42 -0500 Subject: [PATCH 2/6] Removed jobID safety check. --- .../android/database/connect/models/ConnectJobRecord.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java b/app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java index 02d8938280..bd84e3c4d0 100644 --- a/app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java +++ b/app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java @@ -162,7 +162,7 @@ public static ConnectJobRecord fromJson(JSONObject json) throws JSONException, P job.lastLearnUpdate = new Date(); job.lastDeliveryUpdate = new Date(); - job.jobId = json.has(META_JOB_ID) ? json.getInt(META_JOB_ID) : -1; + job.jobId = json.getInt(META_JOB_ID); job.title = json.has(META_NAME) ? json.getString(META_NAME) : ""; job.description = json.has(META_DESCRIPTION) ? json.getString(META_DESCRIPTION) : ""; job.organization = json.has(META_ORGANIZATION) ? json.getString(META_ORGANIZATION) : ""; From ecc4e69674c67ce2ae84f7afbd27c28ada8e8478 Mon Sep 17 00:00:00 2001 From: Dave Viggiano Date: Wed, 6 Mar 2024 09:50:40 -0500 Subject: [PATCH 3/6] Changed login experience to be more stateless, unlocking when needed rather than as a login state. For traditional apps managed by ConnectID, new UX that suggests auto-login but still allows manual login with password. Supporting un/linking ConnectID and traditional apps by prompt after successful login. On Login page, Connect Jobs option integrated into app selector dropdown instead of its own button. --- .../locales/android_translatable_strings.txt | 2 +- app/res/layout/screen_login.xml | 30 --- app/res/values/strings.xml | 9 + .../activities/CommCareSetupActivity.java | 34 +-- .../activities/HomeScreenBaseActivity.java | 1 - .../commcare/activities/LoginActivity.java | 151 ++++++----- .../activities/LoginActivityUiController.java | 96 +++---- .../connect/ConnectDatabaseHelper.java | 14 +- .../ConnectIdRegistrationActivity.java | 2 +- .../activities/connect/ConnectManager.java | 248 +++++++++++++++--- .../activities/connect/ConnectSsoHelper.java | 94 ++++--- .../connect/models/ConnectUserRecord.java | 22 ++ .../connect/ConnectJobIntroFragment.java | 2 +- .../network/CommcareRequestGenerator.java | 2 +- 14 files changed, 436 insertions(+), 271 deletions(-) diff --git a/app/assets/locales/android_translatable_strings.txt b/app/assets/locales/android_translatable_strings.txt index 0f4e51f014..d9ce072707 100644 --- a/app/assets/locales/android_translatable_strings.txt +++ b/app/assets/locales/android_translatable_strings.txt @@ -177,7 +177,7 @@ login.password=Password login.pin.password=PIN login.primed.prompt=Your password has been saved for you! Just press 'Log In'. login.button=Log In -login.app.direct=Login to your app directly. +login.app.connect=Go to Connect Jobs login.sync=Synchronize with server login.bad.password=We couldn't find a user with this password. Please try another! login.welcome.single=Welcome back! Please log in. diff --git a/app/res/layout/screen_login.xml b/app/res/layout/screen_login.xml index 5226e3c889..2f2c7791f1 100644 --- a/app/res/layout/screen_login.xml +++ b/app/res/layout/screen_login.xml @@ -82,26 +82,6 @@ android:textColor="@color/cc_neutral_color" android:textSize="@dimen/text_medium" /> -