Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group spec #27

Open
dbraga opened this issue Oct 2, 2012 · 4 comments
Open

Group spec #27

dbraga opened this issue Oct 2, 2012 · 4 comments

Comments

@dbraga
Copy link
Member

dbraga commented Oct 2, 2012

A lot of code replication (but seems to me its necessary because it's xml response/requests)
Needs reviewal from your point of view

@ghost ghost assigned davide-targa Oct 2, 2012
dbraga added a commit that referenced this issue Oct 2, 2012
@davide-targa
Copy link
Member

work in progress...

@dbraga
Copy link
Member Author

dbraga commented Oct 5, 2012

I took a quick look.
Let's take the save as an example:

After the normal save on spec you add (way to go!) :
it "should return false if you try to save an invalid Group" do.

My concern is that we don't have a valid way to test random failures from google api.
One example could be when you try to save a group that already exists on google groups. How do we fake that?
We use our stub that mimicry the right response but we don't do the same for failures.

Another problem is to subsequential operations like update.
we could test if we really updated the group or the user except we can't because our "find" stub is engineered to response always the same right thing

@dbraga
Copy link
Member Author

dbraga commented Oct 6, 2012

Last commit regards #26 not #27 . my bad

@davide-targa
Copy link
Member

Finally I can confirm that we have a way to test all the behaviors of all the methods.
Thank you VCR
Have a look at specs/user_specs.rb only 350-400 LOC to test ALL the User class!
Pretty impressive! 👍

@ghost ghost assigned dbraga Oct 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants