Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when json isn't a verifiable credential #140

Open
jchartrand opened this issue Oct 7, 2024 · 2 comments · May be fixed by #151
Open

Better error message when json isn't a verifiable credential #140

jchartrand opened this issue Oct 7, 2024 · 2 comments · May be fixed by #151
Assignees

Comments

@jchartrand
Copy link
Contributor

jchartrand commented Oct 7, 2024

When JSON that isn't a verifiable credential is pasted into VerifierPlus, it displays the following error:

image

The error is misleading because it is shown even if the JSON can be parsed. It seems to be a catch-all error for various things including the case where the JSON is not a VC, as in the above example where the JSON was actually an OBv2 (so not a verifiable credential).

Probably want a message more like: "The JSON is not a Verifiable Credential."

And maybe even more specifically - when an OBv2 is pasted in: "This is an OpenBadge V2 which is not a Verifiable Credential. Version 3 of OpenBadges are Verifiable Credentials."

@alexfigtree alexfigtree moved this to Verifier Plus Backlog in DCC Engineering Oct 17, 2024
@santhoshvijay11 santhoshvijay11 self-assigned this Jan 22, 2025
@santhoshvijay11
Copy link
Collaborator

@alexfigtree @kayaelle Could we confirm on the message to be displayed here is it going to be "The JSON is not a Verifiable Credential." or "This is an OpenBadge V2 which is not a Verifiable Credential. Version 3 of OpenBadges are Verifiable Credentials." ?

@kayaelle
Copy link
Member

@santhoshvijay11 - let's use "The JSON is not a Verifiable Credential or an Open Badge 3.0" because those are the two types we accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Verifier Plus Backlog
Development

Successfully merging a pull request may close this issue.

3 participants