Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store aid trackers inline in LowCountState #396

Open
edongashi opened this issue Jun 29, 2022 · 1 comment
Open

Store aid trackers inline in LowCountState #396

edongashi opened this issue Jun 29, 2022 · 1 comment

Comments

@edongashi
Copy link
Member

Why do we have a list of pointers here:

pg_diffix/src/aggregation/low_count.c

Line 44 in f605204

AidTrackerState *trackers[FLEXIBLE_ARRAY_MEMBER];

Why not store AidTrackerStates by value, avoiding the extra pallocs?
@cristianberneanu
Copy link
Collaborator

I think this was implemented so mainly to try to be consistent with state handling in other locations and to keep it easier in the future to make the state variable size, if the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristianberneanu @edongashi