Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to detoast varlen datums before hashing #296

Open
edongashi opened this issue Apr 11, 2022 · 0 comments
Open

Make sure to detoast varlen datums before hashing #296

edongashi opened this issue Apr 11, 2022 · 0 comments

Comments

@edongashi
Copy link
Member

edongashi commented Apr 11, 2022 •
edited
Loading

We hash in a few places (aid, count distinct, bucket seed, ...?). Variable length data can potentially be compressed, and instead of hashing the actual value we hash the compressed bytes.

We need to detoast or at least assert that the values are OK to hash.

PG_DETOAST_DATUM_COPY if you want to make sure the result is always pfreeable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edongashi