Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate "Sample Data" #75

Open
yoid2000 opened this issue Oct 26, 2022 · 3 comments
Open

Relocate "Sample Data" #75

yoid2000 opened this issue Oct 26, 2022 · 3 comments

Comments

@yoid2000
Copy link
Contributor

Currently Metabase include a few "Sample Database" tables.

The basic idea is good (give the user something to play with even if they don't have any tables), but it doesn't match our structure, where everything is either in "Anonymized Data" or "Personal Data" (i.e. Direct Data).

So I think we should have some sample data, maybe even the same four tables that Metabase uses (which is nice in a way because they a JOIN-able). (On the other hand, maybe four tables is too much....maybe two at most.)

Then when Dashboards starts, the sample tables are already shown in the Dashboards "Imported Tables" table, with the appropriate Protected Entity configuration.

Likewise they appear in Metabase under the "Anonymized Data" and "Personal Data" databases.

@pdobacz
Copy link
Collaborator

pdobacz commented Nov 15, 2022

is this one superseded by #119 and can be closed?

@yoid2000
Copy link
Contributor Author

Good question.

The argument for keeping sample data is so that someone can play with the system even if they have no data of their own. (Essentially the same reason that Metabase puts the data there in the first place).

So rather than dopping sample data, we could build sample queries for it in exactly the same way we do it for user data.

These sample queries could be in the executable itself so there is no delay in creating them...

This seems potentially useful to me.

@cristianberneanu
Copy link
Contributor

Not superseded, just simpler to do and higher priority.
After removing the Sample data source, we can add a couple of example tables to our Anonymized/Direct data sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants