feat: [ANDROAPP-6788] Implement new period dialog in filters #3998
Conversation
xavimolloy
force-pushed
the
ANDROAPP-6788-Implement-period-picker-in-filters
branch
from
45e0f37 to
82c1410
Compare
| enrollmentPeriodFilters.clear(); | ||
| try { | ||
| enrollmentPeriodFilters.clear(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
which is the possible exception that we could receive here?
There was a problem hiding this comment.
I noticed that sometimes when applying filters and removing them manually and setting others when navigating back it ocassionally caused an exception due to the list already being empty
There was a problem hiding this comment.
so it is a threading problem. If we wrap it we will have it forever and wouldn't be visible, right?.
Are there stack traces in Sentry?, can we reach to the source of the problem?. May be not in this task
…dule injection to koin
…onent, correct period labels
xavimolloy
force-pushed
the
ANDROAPP-6788-Implement-period-picker-in-filters
branch
from
82c1410 to
51fca2c
Compare
|
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist