ANDROAPP-6802-DatasetInstanceScreen-Saving-and-complete-workflow #3991
+2,232
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmr
force-pushed
the
ANDROAPP-6802-DatasetInstanceScreen-Saving-and-complete-workflow
branch
3 times, most recently
from
6ed9bff to
8223ea1
Compare
andresmr
force-pushed
the
ANDROAPP-6802-DatasetInstanceScreen-Saving-and-complete-workflow
branch
2 times, most recently
from
381ad4d to
615f254
Compare
andresmr
force-pushed
the
ANDROAPP-6802-DatasetInstanceScreen-Saving-and-complete-workflow
branch
from
615f254 to
4b65e11
Compare
xavimolloy
reviewed
Feb 27, 2025
...src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/component/ValidationRulesErrorDialog.kt
Outdated
Show resolved
Hide resolved
...src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/component/ValidationRulesErrorDialog.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/provider/DataSetModalDialogProvider.kt
Show resolved
Hide resolved
...tes/src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/states/DataSetModalDialogUIState.kt
Show resolved
Hide resolved
...ates/src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/viewModel/DataSetTableViewModel.kt
Show resolved
Hide resolved
Balcan
reviewed
Feb 27, 2025
|
xavimolloy
reviewed
Feb 27, 2025
| @@ -18,7 +17,7 @@ class DataSetInstanceActivity : ActivityGlobalAbstract() { | |||
|
|
|||
| override fun onCreate(savedInstanceState: Bundle?) { | |||
| super.onCreate(savedInstanceState) | |||
| enableEdgeToEdge() | |||
| // enableEdgeToEdge() | |||
There was a problem hiding this comment.
is this commented code still needed?
xavimolloy
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
jira issue