Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ANDROAPP-6371] Implements new period picker for datasets #3987

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

ferdyrod
Copy link
Contributor

Description

Please include a summary of the change and include the related jira issue if it exists.

[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@ferdyrod ferdyrod force-pushed the ANDROAPP-6371 branch 2 times, most recently from edc6cab to dc679f1 Compare February 20, 2025 08:00
@ferdyrod ferdyrod requested a review from Balcan February 21, 2025 15:32
Copy link
Contributor

@xavimolloy xavimolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the versioning of the design system and check if there are any methods from date utils that you can remove after deleting the PeriodDialogInputPeriod and period adapter?

@ferdyrod ferdyrod force-pushed the ANDROAPP-6371 branch 2 times, most recently from 6e5927b to 2829ca5 Compare February 25, 2025 15:45
@ferdyrod ferdyrod requested a review from xavimolloy February 25, 2025 15:50
@@ -630,50 +630,6 @@ public void complete_event_with_null_complete_date_throws_error() throws ParseEx

}

@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants