-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [ANDROAPP-6371] Implements new period picker for datasets #3987
base: develop
Are you sure you want to change the base?
Conversation
edc6cab
to
dc679f1
Compare
...ain/java/org/dhis2/usescases/datasets/datasetInitial/periods/DatasetPeriodDialogComponent.kt
Outdated
Show resolved
Hide resolved
...c/main/java/org/dhis2/usescases/datasets/datasetInitial/periods/DatasetPeriodDialogModule.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the versioning of the design system and check if there are any methods from date utils that you can remove after deleting the PeriodDialogInputPeriod and period adapter?
6e5927b
to
2829ca5
Compare
@@ -630,50 +630,6 @@ public void complete_event_with_null_complete_date_throws_error() throws ParseEx | |||
|
|||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
2829ca5
to
a80ea18
Compare
… Periods configured
a80ea18
to
ad3f0c4
Compare
|
…ngeInputPeriodModel class and references
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist