Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reset filters button #23

Open
sawa-kajetan opened this issue Jan 31, 2023 · 2 comments
Open

Add a reset filters button #23

sawa-kajetan opened this issue Jan 31, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sawa-kajetan
Copy link

It seems to be a basic functionality that currently is available only through clicking on all "x" buttons. I have tried to add such functionality, but with the current id and class it seems to be troublesome. A neat "Reset Filters" button under "Add Filter" would be best.

@dgkf dgkf added the enhancement New feature or request label Feb 1, 2023
@dgkf
Copy link
Owner

dgkf commented Feb 1, 2023

Cool idea! I'll have to think through what would be the best way to implement this, but I agree it would be a great quality-of-life enhancement.

Regarding the UI, there are a couple things I'd like to also consider. If a reset button is right next to the add button, then it could easily be misclicked. This might be solved by giving it more space or having a modal confirmation dialog. A few alternatives I'd also consider include:

  • a small button to the right of the Add Filters button
  • a "refresh" button at the top right (above the filters)

@dgkf
Copy link
Owner

dgkf commented Jun 4, 2023

Just revisiting this, and since my reluctance is primarily with the UI, my preferred approach would probably be to add a internal reactive that is exposed from the module to trigger a reset. This way you can add whatever UI you'd like to reset all the fields - for example a button outside the module that just triggers a change to the reset reactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants