#991: Introduce dependencies.json for gradle #1000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj-lorenz
added
enhancement
hj-lorenz
force-pushed
the
feature/991-introduce-dependencies-json-for-gradle
branch
from
8f7fc17 to
8f788de
Compare
cli/src/test/java/com/devonfw/tools/ide/tool/gradle/GradleTest.java
Outdated
Show resolved
Hide resolved
cli/src/test/resources/ide-projects/gradle/_ide/urls/gradle/gradle/8.7/urls
Outdated
Show resolved
Hide resolved
cli/src/test/resources/ide-projects/gradle/_ide/urls/java/java/17.0.10_7/urls
Outdated
Show resolved
Hide resolved
jan-vcapgemini
requested changes
Jan 30, 2025
There was a problem hiding this comment.
@hj-lorenz thank you for the implementation of the dependencies.json for gradle. LGTM, got only some small CRs to resolve.
hohwille
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
@hj-lorenz thanks for your PR. Looks good to me 👍
Can you also link the PR to the ide-urls in the comment of this PR.
What would happen, if we merge the ide-settings and users are still using IDEasy without this change? Does it still work (tying to install java twice) or will it break?
If it does not break, we can merge ide-settings first and then this PR and all should be fine.
Otherwise, we need to complete all of these dependencies.json tasks before we get out of beta since we cause temporary disruptions...
Pull Request Test Coverage Report for Build 13073356411Details
💛 - Coveralls |
Fixes devonfw#991 Removed method "installDependencies Added test-json dependencies.json Added GradleTest and necessary resources Changed permissions to git execute in files
….java Co-authored-by: jan-vcapgemini <[email protected]>
Fixes devonfw#991 Removed url files that are not necessary any more.
Fixes devonfw#991 Removed url files that are not necessary any more. Added necessary .gitkeepfiles
hj-lorenz
force-pushed
the
feature/991-introduce-dependencies-json-for-gradle
branch
from
0663be8 to
793f0b8
Compare
jan-vcapgemini
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #991
Implements
Merging blocked until devonfw/ide-urls#20 is merged