Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Vue or React routers are broken on direct entry pathing #15

Closed
cghiurea opened this issue Jun 28, 2024 · 5 comments
Closed

Bug: Vue or React routers are broken on direct entry pathing #15

cghiurea opened this issue Jun 28, 2024 · 5 comments

Comments

@cghiurea
Copy link

Version: 1.0.7

Create a react or vue spa with a router. If you navigate to the router it will return a 404 with your new change of "prevent path traversal outside content directory"

Context our setup on our dev server is Apache reverse proxy to Spa-to-http to React Spa.
The second setup is Traefik to Spa-to-HTTP to Vue Spa.

It returns a 404 .

image

@Satont
Copy link

Satont commented Jun 30, 2024

Yep, on 1.0.6 version it is working, just tested.

@cghiurea
Copy link
Author

@Satont yes, I forgot to mention version 1.0.6 it works. I had to revert to that version on our production servers.

@sunaley
Copy link

sunaley commented Aug 22, 2024

@Satont yes, I forgot to mention version 1.0.6 it works. I had to revert to that version on our production servers.

I think this might be due to fixing this issue #14 .

@cghiurea
Copy link
Author

It is 100% because it tries to reroute and does not work.

@ivictbor
Copy link
Contributor

This was fixed in 1.0.8 8 month ago.

Just retested:

npm create vue@latest
// set yes in: ✔ Add Vue Router for Single Page Application development? … No / Yes

cd vue-project
npm install

cat <<EOF > Dockerfile
FROM node:20-alpine as builder
WORKDIR /code/
ADD package-lock.json .
ADD package.json .
RUN npm ci
ADD . .
RUN npm run build

FROM devforth/spa-to-http:latest
COPY --from=builder /code/dist/ .
EOF

docker build -q . | xargs docker run --rm -p 8080:8080

Got to http://localhost:8080/about and F5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants